Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): tuiGetElementObscures SSR error TypeError: getBoundingClientRect is not a function #2835

Merged
merged 1 commit into from
Oct 7, 2022
+5 −1
Merged

fix(cdk): tuiGetElementObscures SSR error TypeError: getBoundingClientRect is not a function #2835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion projects/cdk/utils/dom/get-element-obscurers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,15 @@ import {tuiGetDocumentOrShadowRoot} from './get-document-or-shadow-root';
* Returns array of Elements covering edges of given element or null if at least one edge middle point is visible
*
* CAUTION: Empty array means element if offscreen i.e. covered by no elements, rather than not covered
* TODO: v4.0 change function signature to
* ```ts
* function tuiGetElementObscures(element: Element): readonly [Element, Element, Element, Element] | [] | null
* ```
*/
export function tuiGetElementObscures(element: Element): readonly Element[] | null {
const {ownerDocument} = element;

if (!ownerDocument?.defaultView) {
if (!ownerDocument?.defaultView || !element.getBoundingClientRect) {
return null;
}

Expand Down