Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): pseudo elements :after aren't removed in Safari 16 #2825

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 6, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Visit the preview URL for this PR (updated for commit e2ed390):

https://taiga-ui--pr2825-splincode-fix-safari-sly65ztl.web.app

(expires Sat, 08 Oct 2022 08:32:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 39.94% // Head: 39.93% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e2ed390) compared to base (c8ff2d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2825      +/-   ##
==========================================
- Coverage   39.94%   39.93%   -0.01%     
==========================================
  Files         958      959       +1     
  Lines        9248     9257       +9     
  Branches     1901     1901              
==========================================
+ Hits         3694     3697       +3     
- Misses       5350     5356       +6     
  Partials      204      204              
Flag Coverage Δ
addon-charts 73.77% <ø> (ø)
addon-doc 18.72% <ø> (ø)
addon-editor 28.64% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 60.90% <ø> (ø)
kit 19.21% <ø> (+0.03%) ⬆️
summary 39.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/avatar/avatar.component.ts 30.00% <0.00%> (-1.58%) ⬇️
.../kit/components/input-date/input-date.component.ts 10.44% <0.00%> (-0.16%) ⬇️
...nents/input-date-time/input-date-time.component.ts 8.60% <0.00%> (-0.10%) ⬇️
...nts/input-date-range/input-date-range.component.ts 8.65% <0.00%> (-0.09%) ⬇️
projects/kit/components/tree/tree.module.ts 100.00% <0.00%> (ø)
projects/core/directives/hint/hint.module.ts 100.00% <0.00%> (ø)
projects/kit/components/arrow/arrow.module.ts 100.00% <0.00%> (ø)
projects/core/components/alert/alert.module.ts 100.00% <0.00%> (ø)
projects/core/components/group/group.module.ts 100.00% <0.00%> (ø)
projects/kit/components/avatar/avatar.module.ts 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/safari16 branch 2 times, most recently from 9dba8b0 to 2818390 Compare October 7, 2022 05:30
@splincode splincode changed the title WIP fix(styles): pseudo elements ::after aren't removed in Safari 16 fix(styles): pseudo elements ::after aren't removed in Safari 16 Oct 7, 2022
@splincode splincode changed the title fix(styles): pseudo elements ::after aren't removed in Safari 16 fix(styles): pseudo elements :after aren't removed in Safari 16 Oct 7, 2022
@splincode splincode requested a review from nsbarsukov October 7, 2022 08:01
@waterplea
Copy link
Collaborator

We narrowed styles to Safari with hyphen hack, can we narrow it even more to Safari 16 with @supports (text-indent: each-line):
https://caniuse.com/css-text-indent

@splincode splincode force-pushed the splincode/fix/safari16 branch from 2818390 to e2ed390 Compare October 7, 2022 08:28
@splincode splincode merged commit fdab37a into main Oct 7, 2022
@splincode splincode deleted the splincode/fix/safari16 branch October 7, 2022 08:42
@well-done-bot
Copy link

well-done-bot bot commented Oct 7, 2022

'Well done'

@splincode splincode linked an issue Oct 7, 2022 that may be closed by this pull request
@tinkoff-bot tinkoff-bot mentioned this pull request Oct 11, 2022
@splincode splincode linked an issue Nov 2, 2022 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

.tui-skeleton::after in safari
4 participants