fix(kit): InputFlies new value of i18n-token TUI_INPUT_FILE_TEXTS triggers text changes
#2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
requested review from
waterplea,
MarsiBarsi and
vladimirpotekhin
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
nsbarsukov
changed the title
InputFlies no text changes with new value of i18n-token TUI_INPUT_FILE_TEXTSInputFlies trigger text changes with new value of i18n-token TUI_INPUT_FILE_TEXTS
|
Visit the preview URL for this PR (updated for commit 2cd06ac): https://taiga-ui--pr2711-input-files-i18n-fix-c1e3bg58.web.app (expires Fri, 16 Sep 2022 14:42:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
nsbarsukov
changed the title
InputFlies trigger text changes with new value of i18n-token TUI_INPUT_FILE_TEXTSInputFlies new value of i18n-token TUI_INPUT_FILE_TEXTS triggers text changes
splincode
approved these changes
Sep 15, 2022
splincode
reviewed
Sep 15, 2022
Comment on lines
143
to
151
| @tuiPure | ||
| getMaxSizeRejectionError$(maxFileSize: number): Observable<string> { | ||
| return combineLatest([this.inputFileTexts$, this.units$]).pipe( | ||
| map( | ||
| ([{maxSizeRejectionReason}, units]) => | ||
| maxSizeRejectionReason + tuiFormatSize(units, maxFileSize), | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
can make it better in a separate pipe?
<ng-template #maxSizeRejection>
{{ maxFileSize | maxSizeRejectionError | async ?? '' }}
</ng-template>
Codecov Report
@@ Coverage Diff @@
## main #2711 +/- ##
==========================================
- Coverage 56.68% 56.67% -0.02%
==========================================
Files 955 956 +1
Lines 9233 9237 +4
Branches 1894 1894
==========================================
+ Hits 5234 5235 +1
- Misses 3588 3591 +3
Partials 411 411
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nsbarsukov
commented
Sep 15, 2022
|
|
||
| cy.get(`#demoContent tui-file`) | ||
| .should(`contain.text`, `Wrong file type`) | ||
| .matchImageSnapshot(`01-01-input-files-[english]-wrong-file-type`); |
|
|
||
| cy.get(`#demoContent tui-file`) | ||
| .should(`contain.text`, `Verkeerd bestandsformaat`) | ||
| .matchImageSnapshot(`01-02-input-files-[dutch]-wrong-file-type`); |
|
|
||
| cy.get(`#demoContent tui-file`) | ||
| .should(`contain.text`, `File is too large 2 KB`) | ||
| .matchImageSnapshot(`02-01-input-files-[english]-file-too-large`); |
|
|
||
| cy.get(`#demoContent tui-file`) | ||
| .should(`contain.text`, `Bestandsgrootte overschreden 2 KB`) | ||
| .matchImageSnapshot(`02-02-input-files-[dutch]-file-too-large`); |
|
|
nsbarsukov
added a commit
that referenced
this pull request
Sep 16, 2022
… triggers text changes (#2711) Cherry-picked from `v3.x`
Merged
11 tasks
nsbarsukov
added a commit
that referenced
this pull request
Sep 16, 2022
… triggers text changes (#2711) Cherry-picked from `v3.x`
evantrimboli
pushed a commit
to evantrimboli/taiga-ui
that referenced
this pull request
Sep 20, 2022
… triggers text changes (taiga-family#2711) * fix(kit): `InputFlies` no text changes with new value of i18n-token `TUI_INPUT_FILE_TEXTS` * chore(demo-integrations): new cypress tests * refactor: create `tuiMaxSizeRejectionError`-pipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #2709
What is the new behavior?
You can dynamically change language of error messages for rejected files.
Does this PR introduce a breaking change?