Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support text-overflow in tuiTextfield #2657

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the new behavior?

1-06-character-descenders snap
1-07-very-long-text-without-text-ellipsis snap

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 9, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Visit the preview URL for this PR (updated for commit 30513e5):

https://taiga-ui--pr2657-splincode-fix-text-o-6qcfkjlg.web.app

(expires Sat, 10 Sep 2022 12:22:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2657 (30513e5) into main (b373af1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   56.70%   56.70%           
=======================================
  Files         955      955           
  Lines        9233     9233           
  Branches     1897     1897           
=======================================
  Hits         5236     5236           
  Misses       3587     3587           
  Partials      410      410           
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.16% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 62.86% <ø> (ø)
kit 61.58% <ø> (ø)
summary 56.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imitive-textfield/textfield/textfield.component.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@splincode splincode merged commit 9b72134 into main Sep 12, 2022
@splincode splincode deleted the splincode/fix/text-overflow branch September 12, 2022 07:51
@well-done-bot
Copy link

well-done-bot bot commented Sep 12, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants