Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Tiles add reorder strategies #10360

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

kulagind
Copy link
Contributor

Fixes #6576.

@kulagind kulagind requested a review from a team as a code owner February 13, 2025 10:10
@kulagind kulagind requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team February 13, 2025 10:10
Copy link

lumberjack-bot bot commented Feb 13, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (5da8fec) to head (fa94edc).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
projects/kit/components/tiles/tiles.component.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10360      +/-   ##
==========================================
+ Coverage   65.67%   65.75%   +0.07%     
==========================================
  Files        1247     1249       +2     
  Lines       16316    16347      +31     
  Branches     2380     2370      -10     
==========================================
+ Hits        10716    10749      +33     
- Misses       5359     5412      +53     
+ Partials      241      186      -55     
Flag Coverage Δ
summary 65.75% <89.47%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Feb 13, 2025

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
310.36KB (+250B +0.08%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.29KB +10%
demo/browser/runtime.(hash).js
46.95KB +10%
demo/browser/styles.(hash).css
20.96KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +249B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
8MB (+270B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin changed the title Add reorder strategies feat(kit): Tiles add reorder strategies Feb 13, 2025
@kulagind kulagind requested a review from waterplea February 17, 2025 05:30
@waterplea waterplea merged commit 1277754 into taiga-family:main Feb 17, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Reorder - items moves incorrectly when continuously dragging or when the container is overflowed
3 participants