ci: support import/no-cycle (#2890)

.eslintrc.js

@@ -41,6 +41,7 @@ module.exports = {
         },
     },
     rules: {
+        'import/no-cycle': 'error',
         'file-progress/activate': 1,
         quotes: 'off',
         '@typescript-eslint/quotes': ['error', 'backtick'],

projects/addon-charts/components/line-chart/line-chart-hint.directive.ts

@@ -25,6 +25,8 @@ import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 import {combineLatest, Observable} from 'rxjs';
 import {distinctUntilChanged, filter, map, startWith, takeUntil} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiLineChartComponent} from './line-chart.component';
 
 @Directive({

projects/addon-charts/components/line-chart/line-chart.component.ts

@@ -32,6 +32,8 @@ import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 import {Observable, Subject} from 'rxjs';
 import {distinctUntilChanged} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiLineChartHintDirective} from './line-chart-hint.directive';
 
 @Component({

projects/addon-charts/components/line-days-chart/line-days-chart-hint.directive.ts

@@ -24,6 +24,8 @@ import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 import {combineLatest, Observable} from 'rxjs';
 import {filter, map, takeUntil} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiLineDaysChartComponent} from './line-days-chart.component';
 
 // TODO: Consider extending TuiLineChartHintDirective

projects/addon-charts/components/line-days-chart/line-days-chart.component.ts

@@ -28,6 +28,8 @@ import {TuiDriver, TuiPoint} from '@taiga-ui/core';
 import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 import {Observable} from 'rxjs';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiLineDaysChartHintDirective} from './line-days-chart-hint.directive';
 
 const DUMMY: TuiPoint = [NaN, NaN];

projects/addon-editor/extensions/image-editor/image-editor.component.ts

@@ -5,7 +5,7 @@ import {TuiDestroyService, tuiTypedFromEvent} from '@taiga-ui/cdk';
 import {merge} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
 
-import {TuiEditableImage} from './image-editor.extension';
+import type {TuiEditableImage} from './image-editor.extension';
 
 export const TUI_EDITOR_MIN_IMAGE_WIDTH = new InjectionToken<number>(
     `[TUI_EDITOR_MIN_IMAGE_WIDTH]: Min size of resizable image inside editor`,

projects/addon-mobile/components/sheet/components/sheet/sheet.component.ts

@@ -21,6 +21,8 @@ import {fakeSmoothScroll} from '../../ios.hacks';
 import {TuiSheet, TuiSheetRequiredProps} from '../../sheet';
 import {TUI_SHEET_SCROLL} from '../../sheet-tokens';
 import {TUI_SHEET_ID} from '../sheet-heading/sheet-heading.component';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TUI_SHEET_PROVIDERS} from './sheet.providers';
 
 @Component({

projects/addon-mobile/components/sheet/components/sheet/sheet.providers.ts

@@ -7,6 +7,8 @@ import {map, mapTo, share} from 'rxjs/operators';
 
 import {iosScrollFactory} from '../../ios.hacks';
 import {TUI_SHEET, TUI_SHEET_DRAGGED, TUI_SHEET_SCROLL} from '../../sheet-tokens';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiSheetComponent} from './sheet.component';
 
 export const TUI_SHEET_PROVIDERS: Provider[] = [

projects/addon-mobile/components/sheet/sheet.ts

@@ -2,7 +2,7 @@ import {TuiContextWithImplicit} from '@taiga-ui/cdk';
 import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 import {Observable, Observer} from 'rxjs';
 
-import {TuiSheetOptions} from './sheet-options';
+import type {TuiSheetOptions} from './sheet-options';
 
 export interface TuiSheet<O, I = undefined>
     extends TuiSheetOptions<I, O>,

projects/addon-mobile/directives/sidebar/sidebar.component.ts

@@ -14,6 +14,8 @@ import {
 } from '@taiga-ui/core';
 import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiSidebarDirective} from './sidebar.directive';
 
 @Component({

projects/addon-mobile/directives/sidebar/sidebar.directive.ts

@@ -12,6 +12,8 @@ import {TuiDropdownPortalService} from '@taiga-ui/cdk';
 import {TuiHorizontalDirection} from '@taiga-ui/core';
 import {PolymorpheusComponent, PolymorpheusTemplate} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiSidebarComponent} from './sidebar.component';
 
 @Directive({

projects/addon-table/components/table/directives/sort-by.directive.ts

@@ -10,6 +10,8 @@ import {TuiComparator} from '@taiga-ui/addon-table/types';
 import {EMPTY_QUERY, tuiDefaultProp} from '@taiga-ui/cdk';
 import {filter, map} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiSortableDirective} from './sortable.directive';
 import {TuiTableDirective} from './table.directive';
 

projects/addon-table/components/table/directives/sortable.directive.ts

@@ -2,6 +2,8 @@ import {Directive, DoCheck, forwardRef, Inject, OnInit} from '@angular/core';
 import {TuiComparator} from '@taiga-ui/addon-table/types';
 
 import {TuiThComponent} from '../th/th.component';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiSortByDirective} from './sort-by.directive';
 import {TuiTableDirective} from './table.directive';
 

projects/addon-table/components/table/directives/table.directive.ts

@@ -14,6 +14,8 @@ import {TUI_MODE, TuiBrightness, TuiSizeL, TuiSizeS} from '@taiga-ui/core';
 import {Observable} from 'rxjs';
 
 import {TUI_STUCK} from '../providers/stuck.provider';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TUI_TABLE_PROVIDERS} from '../providers/table.providers';
 
 @Directive({

projects/addon-table/components/table/providers/table.providers.ts

@@ -13,6 +13,8 @@ import {
 } from '@taiga-ui/core';
 import {TUI_INPUT_COUNT_OPTIONS, TuiInputCountOptions} from '@taiga-ui/kit';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiTableDirective} from '../directives/table.directive';
 import {TUI_STUCK_PROVIDER} from './stuck.provider';
 

projects/addon-table/components/table/tbody/tbody.component.ts

@@ -17,6 +17,8 @@ import {TuiRowDirective} from '../directives/row.directive';
 import {TuiTableDirective} from '../directives/table.directive';
 import {TuiTableSortPipe} from '../pipes/table-sort.pipe';
 import {TUI_TABLE_PROVIDER} from '../providers/table.provider';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiTrComponent} from '../tr/tr.component';
 
 @Component({

projects/addon-table/components/table/tr/tr.component.ts

@@ -12,6 +12,8 @@ import {map, startWith} from 'rxjs/operators';
 import {TuiCellDirective} from '../directives/cell.directive';
 import {TuiTableDirective} from '../directives/table.directive';
 import {TUI_TABLE_PROVIDER} from '../providers/table.provider';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiTbodyComponent} from '../tbody/tbody.component';
 
 @Component({

projects/cdk/abstract/portal-host.ts

@@ -13,6 +13,8 @@ import {
 } from '@angular/core';
 import {PolymorpheusComponent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {AbstractTuiPortalService} from './portal-service';
 
 /**

projects/cdk/abstract/portal-service.ts

@@ -2,6 +2,8 @@ import {ComponentRef, EmbeddedViewRef, Injectable, TemplateRef} from '@angular/c
 import {TuiNoHostException} from '@taiga-ui/cdk/exceptions';
 import {PolymorpheusComponent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {AbstractTuiPortalHostComponent} from './portal-host';
 
 /**

projects/cdk/directives/auto-focus/autofocus.options.ts

@@ -11,7 +11,10 @@ import {TuiFocusableElementAccessor} from '@taiga-ui/cdk/interfaces';
 import {TUI_FOCUSABLE_ITEM_ACCESSOR, TUI_IS_IOS} from '@taiga-ui/cdk/tokens';
 import {Observable} from 'rxjs';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiDefaultAutofocusHandler} from './handlers/default.handler';
+// eslint-disable-next-line import/no-cycle
 import {TuiIosAutofocusHandler} from './handlers/ios.handler';
 
 export interface TuiAutofocusHandler {

projects/cdk/directives/auto-focus/handlers/abstract.handler.ts

@@ -4,7 +4,7 @@ import {
     TuiNativeFocusableElement,
 } from '@taiga-ui/cdk/interfaces';
 
-import {TuiAutofocusHandler} from '../autofocus.options';
+import type {TuiAutofocusHandler} from '../autofocus.options';
 
 @Directive()
 export abstract class AbstractTuiAutofocusHandler implements TuiAutofocusHandler {

projects/cdk/directives/auto-focus/handlers/default.handler.ts

@@ -6,6 +6,8 @@ import {TUI_FOCUSABLE_ITEM_ACCESSOR} from '@taiga-ui/cdk/tokens';
 import {Observable, race, timer} from 'rxjs';
 import {map, skipWhile, take, throttleTime} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {AbstractTuiAutofocusHandler} from './abstract.handler';
 
 const TIMEOUT = 1000;

projects/cdk/directives/auto-focus/handlers/ios.handler.ts

@@ -12,6 +12,8 @@ import {TuiFocusableElementAccessor} from '@taiga-ui/cdk/interfaces';
 import {TUI_FOCUSABLE_ITEM_ACCESSOR} from '@taiga-ui/cdk/tokens';
 import {tuiPx} from '@taiga-ui/cdk/utils';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {AbstractTuiAutofocusHandler} from './abstract.handler';
 
 @Directive()

projects/cdk/directives/let/let-context.ts

@@ -1,6 +1,6 @@
 import {TuiContextWithImplicit} from '@taiga-ui/cdk/interfaces';
 
-import {TuiLetDirective} from './let.directive';
+import type {TuiLetDirective} from './let.directive';
 
 /**
  * @internal

projects/core/components/data-list/data-list.component.ts

@@ -29,6 +29,8 @@ import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 import {Observable} from 'rxjs';
 import {map} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiOptionComponent} from './option/option.component';
 
 // TODO: Consider aria-activedescendant for proper accessibility implementation

projects/core/components/data-list/option/option.component.ts

@@ -25,6 +25,8 @@ import {TuiOptionRole, TuiSizeL, TuiSizeXS} from '@taiga-ui/core/types';
 import {shouldCall} from '@tinkoff/ng-event-plugins';
 import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiDataListComponent} from '../data-list.component';
 
 function shouldFocus({currentTarget}: TuiEventWith<MouseEvent, HTMLElement>): boolean {

projects/core/directives/dropdown/dropdown.component.ts

@@ -23,6 +23,8 @@ import {TuiPoint} from '@taiga-ui/core/types';
 import {Observable} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiDropdownDirective} from './dropdown.directive';
 import {TuiDropdownHoverDirective} from './dropdown-hover.directive';
 import {

projects/core/directives/dropdown/dropdown.directive.ts

@@ -25,6 +25,8 @@ import {TuiPortalItem} from '@taiga-ui/core/interfaces';
 import {tuiCheckFixedPosition} from '@taiga-ui/core/utils';
 import {PolymorpheusComponent, PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TUI_DROPDOWN_COMPONENT} from './dropdown.providers';
 
 @Directive({

projects/core/directives/dropdown/dropdown.providers.ts

@@ -1,5 +1,7 @@
 import {InjectionToken, Type} from '@angular/core';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiDropdownComponent} from './dropdown.component';
 
 export const TUI_DROPDOWN_COMPONENT = new InjectionToken<Type<any>>(

projects/core/mask/text-mask-options.ts

@@ -1,6 +1,6 @@
-import {TuiTextMaskList} from './text-mask-list';
-import {TuiTextMaskListHandler} from './text-mask-list-handler';
-import {TuiTextMaskPipeHandler} from './text-mask-pipe-handler';
+import type {TuiTextMaskList} from './text-mask-list';
+import type {TuiTextMaskListHandler} from './text-mask-list-handler';
+import type {TuiTextMaskPipeHandler} from './text-mask-pipe-handler';
 
 /**
  * {@link https://github.com/text-mask/text-mask/blob/master/componentDocumentation.md}

projects/core/mask/text-mask-pipe-handler.ts

@@ -1,6 +1,6 @@
-import {TuiTextMaskConfig} from './text-mask-config';
-import {TuiTextMaskOptions} from './text-mask-options';
-import {TuiTextMaskPipeResult} from './text-mask-pipe-result';
+import type {TuiTextMaskConfig} from './text-mask-config';
+import type {TuiTextMaskOptions} from './text-mask-options';
+import type {TuiTextMaskPipeResult} from './text-mask-pipe-result';
 
 /**
  * {@link https://github.com/text-mask/text-mask/blob/master/componentDocumentation.md#pipe}

projects/core/tokens/ordered-short-week-days.ts

@@ -1,12 +1,12 @@
 /**
  * TODO: v4.0 delete the whole file
  */
-
 import {inject, InjectionToken} from '@angular/core';
 import {Observable} from 'rxjs';
 import {map} from 'rxjs/operators';
 
-import {TUI_FIRST_DAY_OF_WEEK, TUI_SHORT_WEEK_DAYS} from './index';
+import {TUI_FIRST_DAY_OF_WEEK} from './first-day-of-week';
+import {TUI_SHORT_WEEK_DAYS} from './i18n';
 
 /**
  * @deprecated

projects/demo/src/modules/app/customization/customization.component.ts

@@ -7,6 +7,8 @@ import {TuiBrightness} from '@taiga-ui/core';
 import {Subject} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {
     TUI_DOC_CUSTOMIZATION_PROVIDERS,
     TUI_DOC_CUSTOMIZATION_VARS,

projects/demo/src/modules/app/customization/customization.providers.ts

@@ -4,6 +4,8 @@ import {TuiDestroyService} from '@taiga-ui/cdk';
 import {TuiModeDirective} from '@taiga-ui/core';
 
 import {CSS_VARS} from '../../tokens/css-vars';
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiCustomizationComponent} from './customization.component';
 
 export const TUI_DOC_CUSTOMIZATION_VARS = new InjectionToken<Record<string, string>>(

projects/demo/src/modules/components/pdf-viewer/examples/2/actions-content.component.ts

@@ -3,7 +3,7 @@ import {TuiDialog} from '@taiga-ui/cdk';
 import {TuiPdfViewerOptions} from '@taiga-ui/kit';
 import {POLYMORPHEUS_CONTEXT} from '@tinkoff/ng-polymorpheus';
 
-import {Buttons} from './index';
+import type {Buttons} from './index';
 
 @Component({
     template: `

projects/demo/src/modules/components/pdf-viewer/examples/2/index.ts

@@ -7,6 +7,8 @@ import {TuiPdfViewerOptions, TuiPdfViewerService} from '@taiga-ui/kit';
 import {PolymorpheusComponent} from '@tinkoff/ng-polymorpheus';
 import {switchMap} from 'rxjs/operators';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {ActionsContent} from './actions-content.component';
 import {PdfContent} from './pdf-content.component';
 

projects/demo/src/modules/components/tree/examples/7/index.ts

@@ -9,6 +9,8 @@ import {
     TuiTreeService,
 } from '@taiga-ui/kit';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TreeLoader} from './service';
 
 export interface Item {

projects/demo/src/modules/components/tree/examples/7/service.ts

@@ -3,7 +3,7 @@ import {TuiTreeLoader} from '@taiga-ui/kit';
 import {Observable, timer} from 'rxjs';
 import {mapTo} from 'rxjs/operators';
 
-import {Item} from './index';
+import type {Item} from './index';
 
 @Injectable()
 export class TreeLoader implements TuiTreeLoader<Item> {

projects/kit/components/arrow/arrow-options.ts

@@ -3,6 +3,8 @@ import {TuiContextWithImplicit} from '@taiga-ui/cdk';
 import {TuiSizeL, TuiSizeM, TuiSizeS} from '@taiga-ui/core';
 import {PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TUI_ARROW} from './arrow.component';
 
 export interface TuiArrowOptions {

projects/kit/components/arrow/arrow.component.ts

@@ -7,6 +7,8 @@ import {
 } from '@taiga-ui/core';
 import {PolymorpheusComponent, PolymorpheusContent} from '@tinkoff/ng-polymorpheus';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TUI_ARROW_OPTIONS, TuiArrowOptions} from './arrow-options';
 
 @Component({

projects/kit/components/push/push-alert.component.ts

@@ -7,10 +7,9 @@ import {
     tuiHeightCollapse,
     tuiSlideInRight,
 } from '@taiga-ui/core';
-import {POLYMORPHEUS_CONTEXT} from '@tinkoff/ng-polymorpheus';
+import {POLYMORPHEUS_CONTEXT, PolymorpheusTemplate} from '@tinkoff/ng-polymorpheus';
 
 import {TuiPushOptions} from './push.options';
-import {TuiPushAlertDirective} from './push-alert.directive';
 
 @Component({
     selector: `tui-push-alert`,
@@ -33,6 +32,6 @@ export class TuiPushAlertComponent {
     ) {}
 
     get isDirective(): boolean {
-        return this.context.content instanceof TuiPushAlertDirective;
+        return this.context.content instanceof PolymorpheusTemplate;
     }
 }

projects/kit/components/slider/helpers/slider-key-steps.directive.ts

@@ -23,6 +23,8 @@ import {
     tuiPercentageToKeyStepValue,
 } from '@taiga-ui/kit/utils';
 
+// TODO: find the best way for prevent cycle
+// eslint-disable-next-line import/no-cycle
 import {TuiSliderComponent} from '../slider.component';
 
 @Directive({