[opengl] add TI_ENABLE_OPENGL env var to disable OpenGL #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
requested review from
yuanming-hu and
k-ye
and removed request for
yuanming-hu
|
Thanks! I'm at a meeting but I'll take a look in the afternoon! Please don't wait for me - take care and get enough sleep :-) |
yuanming-hu
reviewed
May 12, 2020
taichi/util/environ_config.h
Outdated
|
|
||
| TLANG_NAMESPACE_BEGIN | ||
|
|
||
| static int get_environ_config(const std::string &name, int default_value = 0) |
There was a problem hiding this comment.
Does it make sense to make an interface like template <typename T> get_environ_config(const std::string &name, const T &default_value) { ... }, and then specialize it for int?
There was a problem hiding this comment.
I guess use override functions instead of T is better idea, since the func stoi and stof.
There was a problem hiding this comment.
You can always use different conversion functions in different specializations. Or you can simply use if constexpr.
yuanming-hu
approved these changes
May 13, 2020
yuanming-hu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #958 (comment)
[Click here for the format server]