[ir] Fix compilation crash when offloading LocalStoreStmt and AtomicOpStmt #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuanming-hu
reviewed
Apr 18, 2020
| @@ -278,6 +278,15 @@ bool Stmt::have_operand(Stmt *stmt) const { | |||
| return false; | |||
| } | |||
|
|
|||
| int Stmt::locate_operand(Stmt **stmt) { | |||
| for (int i = 0; i < num_operands(); i++) { | |||
There was a problem hiding this comment.
Here should we consider something like $1 = add $0, $0?
There was a problem hiding this comment.
And we should probably add the tests in.
There was a problem hiding this comment.
I used Stmt ** rather than Stmt *, so I think the values like the same $0s wouldn't affect.
There was a problem hiding this comment.
And we should probably add the tests in.
Yeah, we should add #812 (comment) in. But I haven't come up with the name of the test.
(I don't think locate_operand need tests)
|
I'm merging this in, for now, to fix the issue in #814. Let's resolve the comment later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR = #812
[Click here for the format server]