-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] [refactor] Support parameter passing for argpack #8104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 31, 2023
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: ac57c9b3ae0ed091f1d4d3022ce60c54dedd72f7 Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: 4d71e52a772e98f9d05b92d5666771344f0fdc63 Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: 3131fcdd3959beb1f1a1b3b434ce301da6bf1a1b Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: d32a8ae97d477b6cc9e1c5e0b8ac5adf7a7f59f3 Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: 7d15427d690513a644097c533af432eff68c81c6 Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: b7ce6d931ba479865e3d2c21c54f4d72d85b07d3 Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: c5aabf6016bdfbcabafd059ff2dea21ddd483e4b Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 31, 2023
ghstack-source-id: 627abde2fc531af6d8844b3b62c7f168a73f35fb Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 5, 2023
ghstack-source-id: ba88a3f8d0407c02dd5bb33851a7b979ea22075c Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 5, 2023
ghstack-source-id: f7dc24b27aa17b3059d5948dbbcfbb20729fbe92 Pull Request resolved: #8104
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: c6980270bcd2a3a38cd396e5783ed44bd47ff841 Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: 61922a5d387eed3cf68e4ec2d9ed8375c430475d Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: ef98c4df532775124c0c4da45eae11031db96997 Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: 7bf6c3517c7b31e0542a6d00593544138f39d9d6 Pull Request resolved: #8104
for more information, see https://pre-commit.ci
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: f390f0b295b8b4ef2558189939c2d34ef424a1cd Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: 12eeb607b72ef2a28f8fb63bfd4e64454c121b91 Pull Request resolved: #8104
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 6, 2023
ghstack-source-id: d2f7a82a3df7ca78e8a61b5c22a368c96d188cc6 Pull Request resolved: #8104
[ghstack-poisoned]
lin-hitonami
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Jun 9, 2023
taichi-gardener
pushed a commit
that referenced
this pull request
Jun 9, 2023
ghstack-source-id: 46bac7c0555cbc45e4172a1b1a7ccc3a1763f138 Pull Request resolved: #8104
L2ncE
pushed a commit
to L2ncE/taichi
that referenced
this pull request
Jun 20, 2023
ghstack-source-id: 46bac7c0555cbc45e4172a1b1a7ccc3a1763f138 Pull Request resolved: taichi-dev#8104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):