[bug] Fix SparseMatrix's dtype; check for dtype in SparseSolver. #8071
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8045
Brief Summary
SparseMatrix
's dtype should be determined by the dtype of theSparseMatrixBuilder
from which it's built. However, it's fixed tof32
in the current code base. This PR fix this by passingself.dtype
instead ofdtype
toSparseMatrix()
in the builder:Also,
SparseSolver
should raise an exception to better notify the user if thedtype
of theSparseMatrix
is not consistent with the solver'sdtype
. This is implemented in thesparse_solver.py
.Additional comments