Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Exclude quant type when doing store-to-load forwarding and skip bit struct store fusion when unfeasible #8023

Merged
merged 12 commits into from
May 24, 2023
Merged

[bug] Exclude quant type when doing store-to-load forwarding and skip bit struct store fusion when unfeasible #8023

merged 12 commits into from
May 24, 2023

Conversation

dream189free
Copy link
Contributor

@dream189free dream189free commented May 16, 2023 •
edited by ghost
Loading

Issue: #7981

Brief Summary

🤖 Generated by Copilot at cef23dc

Exclude qi4 store pointers from forwarding optimization in live variable analysis. This prevents precision loss when quantizing integers in the Taichi compiler.

Walkthrough

🤖 Generated by Copilot at cef23dc

  • Exclude quantized integer store pointers from forwarding optimization to avoid precision loss (link)

@netlify
Copy link

netlify bot commented May 16, 2023 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit e89de44
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/646c4a7d63d7c900083cb17b
😎 Deploy Preview https://deploy-preview-8023--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dream189free dream189free changed the title [bug] Exclude quant type when doing store-to-load forwarding (WIP, Don't Merge) [bug] Exclude quant type when doing store-to-load forwarding May 22, 2023
@dream189free dream189free changed the title [bug] Exclude quant type when doing store-to-load forwarding [bug] Exclude quant type when doing store-to-load forwarding and skip bit struct store fusion when unfeasible May 22, 2023
@dream189free dream189free requested a review from jim19930609 May 22, 2023 12:51
jim19930609
jim19930609 approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellence! btw is there an unit test for the case of "Load between BitStores"?

taichi/transforms/optimize_bit_struct_stores.cpp Outdated Show resolved Hide resolved
taichi/ir/control_flow_graph.cpp Outdated Show resolved Hide resolved
@dream189free dream189free requested a review from jim19930609 May 23, 2023 06:45
@dream189free dream189free merged commit 3660ac8 into taichi-dev:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim19930609 jim19930609 Awaiting requested review from jim19930609

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dream189free @jim19930609