-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] Added u1 as boolean type to taichi lang, replacing i32 #8021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 16, 2023
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: 6a357cd36a8ab8f6a0f2d6e1af5aa1a554217337 Pull Request resolved: #8021
…i32" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: 355322e4b2b19b80a648bc74430a2f61a9746596 Pull Request resolved: #8021
…i32" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: 340bd487d8fb64024197d1f56dffa84b8304ba0b Pull Request resolved: #8021
…i32" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: cd45ca08dbd7e1f0962da076b3cd1cb2ee9ad1e0 Pull Request resolved: #8021
…i32" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: 382e78d2aa72683759821afd861004fa07466264 Pull Request resolved: #8021
…i32" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: 2ebebf6b0c41af37fd54e8808b86dadd9c91a826 Pull Request resolved: #8021
…i32" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: eb7c9a1f5da87252dc1e78902a70cb958be3ceda Pull Request resolved: #8021
…i32" [ghstack-poisoned]
for more information, see https://pre-commit.ci
…i32" [ghstack-poisoned]
for more information, see https://pre-commit.ci
…i32" [ghstack-poisoned]
for more information, see https://pre-commit.ci
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
…i32" [ghstack-poisoned]
This was referenced May 17, 2023
lin-hitonami
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
taichi-gardener
pushed a commit
that referenced
this pull request
May 18, 2023
ghstack-source-id: 242a65540f7c8ddd1501d2b2ba0a2f3d68629639 Pull Request resolved: #8021
This was referenced May 18, 2023
neozhaoliang
pushed a commit
that referenced
this pull request
May 23, 2023
Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 0a01646</samp> Document the new `u1` type for boolean values and update the backend support table in `docs/lang/articles/type_system/type.md`. This reflects the new feature of boolean support implemented in PR #8021 . ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 0a01646</samp> * Introduce the `u1` primitive type for boolean values and document its usage and backend support ([link](https://github.com/taichi-dev/taichi/pull/8062/files?diff=unified&w=0#diff-9f9bbba7178ed5b2080200ead56ae466b1daf42ca988950cd825479332a504bbL31-R46), F0L113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):