-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] Added ti.u1 definition #7995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 12, 2023
ghstack-source-id: 0898cae9cab2ea2c26f768aded91185c47ff5798 Pull Request resolved: #7995
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 12, 2023
ghstack-source-id: 7560c53a29419a8aaacc4b0088637ab917d2a972 Pull Request resolved: #7995
[ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
May 12, 2023
ghstack-source-id: ac52abfd5e136811d4a7f3b86d5b36362ed94f4f Pull Request resolved: #7995
This was referenced May 15, 2023
lin-hitonami
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced May 15, 2023
feisuzhu
pushed a commit
that referenced
this pull request
May 16, 2023
ghstack-source-id: ac52abfd5e136811d4a7f3b86d5b36362ed94f4f Pull Request resolved: #7995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR added type
u1
as a definition but not implementation.This pull request adds support for boolean tensors in Taichi by introducing a new
u1
data type and enabling conversions, operations, and code generation for it. It also updates the Python, C++, and graphics interfaces to handle theu1
type and improves the memory efficiency of boolean tensors. It modifies several files in thepython
,taichi
, andtaichi/runtime
directories.ghstack
Stack from ghstack (oldest at bottom):