[bug] Fix extraction of field with offset to external array #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
ailzhang
reviewed
May 8, 2023
ailzhang
reviewed
May 10, 2023
for more information, see https://pre-commit.ci
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…ev#7945) Issue: taichi-dev#7775 ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 44074b9</samp> This pull request adds support for offset tensors in Taichi, which are tensors with non-zero lower bounds for their index domains. It updates the `test_offset.py` file to add more tests, the `tensor_to_ext_arr` function to handle offset copying, and the `SNode` class to expose the offset attribute to Python. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 44074b9</samp> * Add offset attribute to SNode class and expose it to Python interface ([link](https://github.com/taichi-dev/taichi/pull/7945/files?diff=unified&w=0#diff-af631a0c71978fe591e17005f01f7c06bc30ae36c65df306bbb3b08ade770167R471)) * Modify tensor_to_ext_arr function to account for offset attribute when copying data to external array ([link](https://github.com/taichi-dev/taichi/pull/7945/files?diff=unified&w=0#diff-09cd7b8194d05b7454b512d74fc5b442aed2319dcb763e182288b55753ce6feeL42-R48)) * Add test cases to check the correctness of offset tensor's data and conversion methods ([link](https://github.com/taichi-dev/taichi/pull/7945/files?diff=unified&w=0#diff-520d9ca52eed08ca617ef520e95d0d1778fb1943b9652f7a388b63abca00ddd1R148-R162), [link](https://github.com/taichi-dev/taichi/pull/7945/files?diff=unified&w=0#diff-520d9ca52eed08ca617ef520e95d0d1778fb1943b9652f7a388b63abca00ddd1R6)) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7775
Brief Summary
🤖 Generated by Copilot at 44074b9
This pull request adds support for offset tensors in Taichi, which are tensors with non-zero lower bounds for their index domains. It updates the
test_offset.pyfile to add more tests, thetensor_to_ext_arrfunction to handle offset copying, and theSNodeclass to expose the offset attribute to Python.Walkthrough
🤖 Generated by Copilot at 44074b9