[Lang] Remove deprecated sparse_matrix_builder function #7942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
feisuzhu
pushed a commit
that referenced
this pull request
May 9, 2023
Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 6809c08</samp> Removed deprecated `sparse_matrix_builder` class and related code from `sparse_matrix.py` and `test_deprecation.py`. Simplified the `sparse_matrix` module. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 6809c08</samp> * Remove deprecated `sparse_matrix_builder` class and its alias from `sparse_matrix.py` ([link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-e788aae97f9ad8507a4eebc224175b2f9ad6f14359999ca0ea99ad4503fc9dcaL297-R296)) * Remove unused `warnings` and `annotations` modules from `sparse_matrix.py` ([link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-e788aae97f9ad8507a4eebc224175b2f9ad6f14359999ca0ea99ad4503fc9dcaL1), [link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-e788aae97f9ad8507a4eebc224175b2f9ad6f14359999ca0ea99ad4503fc9dcaL10-R9)) * Remove test case for deprecated `sparse_matrix_builder` class from `test_deprecation.py` ([link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L145-L153))
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
) Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 6809c08</samp> Removed deprecated `sparse_matrix_builder` class and related code from `sparse_matrix.py` and `test_deprecation.py`. Simplified the `sparse_matrix` module. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 6809c08</samp> * Remove deprecated `sparse_matrix_builder` class and its alias from `sparse_matrix.py` ([link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-e788aae97f9ad8507a4eebc224175b2f9ad6f14359999ca0ea99ad4503fc9dcaL297-R296)) * Remove unused `warnings` and `annotations` modules from `sparse_matrix.py` ([link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-e788aae97f9ad8507a4eebc224175b2f9ad6f14359999ca0ea99ad4503fc9dcaL1), [link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-e788aae97f9ad8507a4eebc224175b2f9ad6f14359999ca0ea99ad4503fc9dcaL10-R9)) * Remove test case for deprecated `sparse_matrix_builder` class from `test_deprecation.py` ([link](https://github.com/taichi-dev/taichi/pull/7942/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L145-L153))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖 Generated by Copilot at 6809c08
Removed deprecated
sparse_matrix_builderclass and related code fromsparse_matrix.pyandtest_deprecation.py. Simplified thesparse_matrixmodule.Walkthrough
🤖 Generated by Copilot at 6809c08
sparse_matrix_builderclass and its alias fromsparse_matrix.py(link)warningsandannotationsmodules fromsparse_matrix.py(link, link)sparse_matrix_builderclass fromtest_deprecation.py(link)