[lang] Refactor cg solvers #7911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FantasyVR
approved these changes
Apr 28, 2023
neozhaoliang
added a commit
that referenced
this pull request
May 8, 2023
Issue: #7837 ### Brief Summary As a follow-up PR related to issue #7837 and PR #7911, split the description for linear solver from `sparse_matrix.md`. More information will be filled into the additional `linear_solver.md` page once PR #7911 is merged, to reflect the latest usage information of the linear solvers. --------- Co-authored-by: Zhao Liang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#7837 ### Brief Summary As described in Issue taichi-dev#7837 , I first implemented Plan # 1 to enforce a more consistent naming for the current solvers. All solver code are untouched, except for the naming: ``` ti.linalg.SparseSolver => no change ti.linalg.CG => ti.linalg.SparseCG ti.linalg.taichi_cg_solver => ti.linalg.MatrixFreeCG ``` The Python test scripts are also updated accordingly. This doesn't mean Plan # 3 is abandoned though: we can unify `SparseCG` and `MatrixFreeCG` in the future if that's the route we want. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…7921) Issue: taichi-dev#7837 ### Brief Summary As a follow-up PR related to issue taichi-dev#7837 and PR taichi-dev#7911, split the description for linear solver from `sparse_matrix.md`. More information will be filled into the additional `linear_solver.md` page once PR taichi-dev#7911 is merged, to reflect the latest usage information of the linear solvers. --------- Co-authored-by: Zhao Liang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7837
Brief Summary
As described in Issue #7837 , I first implemented Plan # 1 to enforce a more consistent naming for the current solvers. All solver code are untouched, except for the naming:
The Python test scripts are also updated accordingly. This doesn't mean Plan # 3 is abandoned though: we can unify
SparseCGandMatrixFreeCGin the future if that's the route we want.