Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Add cast to field.fill() interface #7899

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

jim19930609
Copy link
Contributor

Issue: ##7678

There's one potential hazard: if the user mistakenly filled a ti.field with out-of-scope values (like filling a ti.field(ti.u8) with > 255), it's just gonna overflow silently.

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 9f07477
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6448c47342610500088d320f
😎 Deploy Preview https://deploy-preview-7899--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neozhaoliang neozhaoliang merged commit bc45b3e into taichi-dev:master Apr 27, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #taichi-dev#7678

There's one potential hazard: if the user mistakenly filled a ti.field
with out-of-scope values (like filling a ti.field(ti.u8) with > 255),
it's just gonna overflow silently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants