-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ir] [lang] Support ti.u1 as boolean type #7882
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # taichi/ir/frontend_ir.cpp
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This PR will be split into a few separate and stacked PRs. It will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #577
Brief Summary
This PR added ti.u1 as boolean type to Taichi Lang.
Walkthrough
Features
Changes
Limitations
Future Work
Support ti.u1 to be used as dtype in compound types
On spir-v, ti.u1 used as compound type like
a = ti.field(ti.u1, 10)
would yield:Support better ti.u1 in print
Find possible solutions to correctly print boolean variables.
Copilot Summary
🤖 Generated by Copilot at 7b21443
This pull request introduces a new boolean type
u1
in Taichi, and updates various parts of the language, compiler, and runtime to support and use the new type. The purpose is to enable the use of boolean values in Taichi and its interoperability with other frameworks, and to fix some bugs and errors related to the boolean type. The pull request modifies several files in thepython
,taichi
, anddocs
directories, such asmatrix_ops.py
,codegen_llvm.cpp
, andllvm_sparse_runtime.md
.