Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Fixed useless serial shader to blit ExternalTensorShapeAlongAxisStmt on Metal #7562

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

PENGUINLIONG
Copy link
Member

Issue: #

Brief Summary

It's already fixed in other SPIR-V powered archs tho. Could we come up with a better way than this sequence of arch checks?

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 3da9f49
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/64106e1d547689000825ed32
😎 Deploy Preview https://deploy-preview-7562--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PENGUINLIONG PENGUINLIONG changed the title [lang] Fixed useless serial shader to blit ExternalTensorShapeAlongAxisStmt [lang] Fixed useless serial shader to blit ExternalTensorShapeAlongAxisStmt on Metal Mar 14, 2023
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PENGUINLIONG PENGUINLIONG merged commit 4280678 into taichi-dev:master Mar 15, 2023
@PENGUINLIONG PENGUINLIONG deleted the experiment branch March 15, 2023 07:32
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…isStmt on Metal (taichi-dev#7562)

Issue: #

### Brief Summary

It's already fixed in other SPIR-V powered archs tho. Could we come up
with a better way than this sequence of arch checks?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants