-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenGL] bitmasked support #737
Conversation
Metal root buffer layout:
OpenGL root buffer layout (for now):
|
TI_ASSERT(stmt->width() == 1); | ||
auto dt = stmt->data->element_type(); | ||
auto ch_addr = stmt->ptr->short_name(); | ||
emit("atomicOr(_rt_.bitmask[{} >> 8], 1 << ({} & 31));", ch_addr, ch_addr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct usage to activate when store?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, activation
should happen on SNodeLookUp
statements. When doing GlobalStore
you should assume the element is already activated.
How to struct_for a bitmasked snode? |
That depends - for intermediate SNode we need a list generation (see x64/CUDA/Metal backends as examples), for leaf SNode |
What is a |
Good questions - I should probably do my job to improve the documentation #736 .... I plan to do this on Sunday. Sorry for blocking you. If you have extra cycles maybe we can have #653 in. Note that it's fine if OpenGL backend in v0.6.0 doesn't support sparse data structures. Metal doesn't support sparse either on its initial release. Most demos so far doesn't require sparsity. We should also include glfw and glew as submodules, and statically link their binary into |
Right, we'll first ship it, then improve it! |
Understood... Setting up CI can be boring due to the long build delay - feel free to do that while watching Bilibili... |
Won't proceed before doc complete, closing for now. |
Related issue = #711
First problem is bitmasked cannot be assigned correctly:
It shows
0 0 0
, it should be at least233 0 0
.Good night!
[Click here for the format server]