Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ir] [refactor] BasicStmtVisitor includes Frontend blocks #732

Merged
merged 2 commits into from
Apr 9, 2020
Merged

[ir] [refactor] BasicStmtVisitor includes Frontend blocks #732

merged 2 commits into from
Apr 9, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = #... (if any)

[Click here for the format server]

@archibate archibate requested a review from yuanming-hu April 9, 2020 04:35
@archibate archibate changed the title BasicStmtVisitor includes Frontend blocks [ir] [refactor] BasicStmtVisitor includes Frontend blocks Apr 9, 2020
@archibate
Copy link
Collaborator Author

Make taichi/analysis/detect_for_with_break.cpp easier, and may refactor #708?

@archibate archibate requested a review from k-ye April 9, 2020 04:37
k-ye
k-ye approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Note that we might need to split IR/Visitors to frontend and CHI lang in the future.

@archibate
Copy link
Collaborator Author

Note that we might need to split IR/Visitors to frontend and CHI lang in the future.

Oh yes, FrontendxxxStmt for TAI and xxxStmt for CHI. I think we may have BasicFrontendStmtVisitor for TAI?

@yuanming-hu
Copy link
Member

Note that we might need to split IR/Visitors to frontend and CHI lang in the future.

Oh yes, FrontendxxxStmt for TAI and xxxStmt for CHI. I think we may have BasicFrontendStmtVisitor for TAI?

Exactly! LGTM, I'm merging it in for now, but in the future let's split the visitors into frontend and middle-end versions.

@yuanming-hu yuanming-hu merged commit b5283a9 into taichi-dev:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archibate @yuanming-hu @k-ye