-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [amdgpu] Enable amdgpu backend python unit tests #7293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
jim19930609
reviewed
Feb 6, 2023
jim19930609
approved these changes
Feb 6, 2023
for more information, see https://pre-commit.ci
galeselee
added a commit
that referenced
this pull request
Feb 15, 2023
Issue: # related #7293 FIXME ### Brief Summary For the sake of code simplicity, the pass is placed at the beginning of the jit instead of where `allocs` was created. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: #taichi-dev#6434 ### Brief Summary 1. fix amdgpu backend bugs: a. codegen typos b. add more types support for `sgn` c. use temporary method to handle `runtime.cpp` error 2. enable amdgpu backend python unit test a. because of the lack of `print` support, temporarily disable all `print` related tests on amdgpu backend. b. there is still something wrong in `gdar_mpm` and `ad_if` tests. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
) Issue: # related taichi-dev#7293 FIXME ### Brief Summary For the sake of code simplicity, the pass is placed at the beginning of the jit instead of where `allocs` was created. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ##6434
Brief Summary
a. codegen typos
b. add more types support for
sgn
c. use temporary method to handle
runtime.cpp
errora. because of the lack of
print
support, temporarily disable allprint
related tests on amdgpu backend.b. there is still something wrong in
gdar_mpm
andad_if
tests.