Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [amdgpu] Enable amdgpu backend python unit tests #7293

Merged
merged 9 commits into from
Feb 6, 2023

Conversation

galeselee
Copy link
Contributor

@galeselee galeselee commented Feb 3, 2023

Issue: ##6434

Brief Summary

  1. fix amdgpu backend bugs:
    a. codegen typos
    b. add more types support for sgn
    c. use temporary method to handle runtime.cpp error
  2. enable amdgpu backend python unit test
    a. because of the lack of print support, temporarily disable all print related tests on amdgpu backend.
    b. there is still something wrong in gdar_mpm and ad_if tests.

@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit a293861
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63e06f0024bc170009c97b27

@galeselee galeselee changed the title [ci][amdgpu] Enable amdgpu backend python unit tests [ci] [amdgpu] Enable amdgpu backend python unit tests Feb 3, 2023
@galeselee galeselee merged commit ef6187b into taichi-dev:master Feb 6, 2023
galeselee added a commit that referenced this pull request Feb 15, 2023
Issue: # related #7293 FIXME

### Brief Summary
For the sake of code simplicity, the pass is placed at the beginning of
the jit instead of where `allocs` was created.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #taichi-dev#6434

### Brief Summary
1. fix amdgpu backend bugs:
    a. codegen typos
    b. add more types support for `sgn`
    c. use temporary method to handle `runtime.cpp` error
2. enable amdgpu backend python unit test
a. because of the lack of `print` support, temporarily disable all
`print` related tests on amdgpu backend.
    b. there is still something wrong in `gdar_mpm` and `ad_if` tests.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
)

Issue: # related taichi-dev#7293 FIXME

### Brief Summary
For the sake of code simplicity, the pass is placed at the beginning of
the jit instead of where `allocs` was created.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants