[llvm] Unify the llvm context of host and device #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
lin-hitonami
force-pushed
the
unify-context
branch
from
8657a48 to
ef8c669
Compare
# Conflicts: # c_api/src/taichi_llvm_impl.cpp # taichi/runtime/llvm/llvm_aot_module_loader.cpp # taichi/runtime/llvm/llvm_runtime_executor.cpp
|
/rerun |
|
/rebase |
|
Rebase failed, please resolve the conflicts manually. |
lin-hitonami
requested review from
jim19930609,
ailzhang and
strongoier
and removed request for
strongoier,
ailzhang and
jim19930609
lin-hitonami
commented
Jan 31, 2023
lin-hitonami
commented
Jan 31, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: fixes taichi-dev#7251 The` llvm_context_host_` and `llvm_context_device_` are never both used in the same backend, so we can unify them and only use a single `llvm_context_`. ### Brief Summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixes #7251
The
llvm_context_host_andllvm_context_device_are never both used in the same backend, so we can unify them and only use a singlellvm_context_.Brief Summary