Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Simplify the swizzle generator #7216

Merged
merged 6 commits into from
Jan 19, 2023
Merged

[Lang] Simplify the swizzle generator #7216

merged 6 commits into from
Jan 19, 2023

Conversation

neozhaoliang
Copy link
Contributor

@neozhaoliang neozhaoliang commented Jan 19, 2023

This PR replaces the SwizzleGenerator.generate() with a simpler function to generate all swizzling patterns.

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit aaa7aea
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c946499b525e0007eedce7
😎 Deploy Preview https://deploy-preview-7216--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang
Copy link
Contributor

/rebase

@neozhaoliang neozhaoliang merged commit 2d30410 into taichi-dev:master Jan 19, 2023
@neozhaoliang neozhaoliang deleted the simple-vector-swizzle branch January 19, 2023 14:28
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
This PR replaces the `SwizzleGenerator.generate()` with a simpler
function to generate all swizzling patterns.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants