Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add doc ndarray #7157

Merged
merged 6 commits into from
Jan 13, 2023
Merged

[doc] Add doc ndarray #7157

merged 6 commits into from
Jan 13, 2023

Conversation

Olinaaaloompa
Copy link
Contributor

Issue: #

Brief Summary

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 94c5235
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c167b265b4770008eb4342
😎 Deploy Preview https://deploy-preview-7157--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes and tips are not shown properly in the preview, otherwise lgtm!

docs/lang/articles/basic/ndarray.md Outdated Show resolved Hide resolved
Comment on lines 146 to 149
:::Note
Every element in the external array (`arr_np` and `arr_torch`) is added by `1.0` when the Taichi kernel `add_one` finishes.
:::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::Note
Every element in the external array (`arr_np` and `arr_torch`) is added by `1.0` when the Taichi kernel `add_one` finishes.
:::
:::note
Every element in the external array (`arr_np` and `arr_torch`) is added by `1.0` when the Taichi kernel `add_one` finishes.
:::

Comment on lines 154 to 156
:::TIPS
NumPy's default data precision is 64-bit, which is still inefficient for most desktop GPUs. It is recommended to explicitly specify 32-bit data types.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::TIPS
NumPy's default data precision is 64-bit, which is still inefficient for most desktop GPUs. It is recommended to explicitly specify 32-bit data types.
:::
:::tip
NumPy's default data precision is 64-bit, which is still inefficient for most desktop GPUs. It is recommended to explicitly specify 32-bit data types.
:::

Comment on lines 158 to 160
:::TIPS
Only contiguous NumPy arrays and PyTorch tensors are supported.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::TIPS
Only contiguous NumPy arrays and PyTorch tensors are supported.
:::
:::tip
Only contiguous NumPy arrays and PyTorch tensors are supported.
:::

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@ailzhang ailzhang merged commit e9c07d5 into taichi-dev:master Jan 13, 2023
lin-hitonami pushed a commit that referenced this pull request Jan 13, 2023
Issue: #

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ailing  <[email protected]>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ailing  <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants