[Bug] Fix ret_type and cast_type of UnaryOpStmt in Scalarize #7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jim19930609
approved these changes
Jan 9, 2023
lin-hitonami
pushed a commit
to lin-hitonami/taichi
that referenced
this pull request
Jan 9, 2023
…dev#7082) Issue: fix taichi-dev#6978 ### Brief Summary After taichi-dev#7068, The `taichi_ngp` example reports `RuntimeError: [type_factory.cpp:promoted_type@222] Assertion failure: a->is<TensorType>() && b->is<TensorType>()`. The root cause is that `taichi_ngp` uses `atomic_sub` on a value with type different from the destination, which will generate `neg` + `cast`. However, the `ret_type` and `cast_type` of `UnaryOpStmt` produced by `Scalarize` aren't set correctly. This PR fixes the problem.
lin-hitonami
pushed a commit
to lin-hitonami/taichi
that referenced
this pull request
Jan 12, 2023
…dev#7082) Issue: fix taichi-dev#6978 ### Brief Summary After taichi-dev#7068, The `taichi_ngp` example reports `RuntimeError: [type_factory.cpp:promoted_type@222] Assertion failure: a->is<TensorType>() && b->is<TensorType>()`. The root cause is that `taichi_ngp` uses `atomic_sub` on a value with type different from the destination, which will generate `neg` + `cast`. However, the `ret_type` and `cast_type` of `UnaryOpStmt` produced by `Scalarize` aren't set correctly. This PR fixes the problem.
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…dev#7082) Issue: fix taichi-dev#6978 ### Brief Summary After taichi-dev#7068, The `taichi_ngp` example reports `RuntimeError: [type_factory.cpp:promoted_type@222] Assertion failure: a->is<TensorType>() && b->is<TensorType>()`. The root cause is that `taichi_ngp` uses `atomic_sub` on a value with type different from the destination, which will generate `neg` + `cast`. However, the `ret_type` and `cast_type` of `UnaryOpStmt` produced by `Scalarize` aren't set correctly. This PR fixes the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fix #6978
Brief Summary
After #7068, The
taichi_ngpexample reportsRuntimeError: [type_factory.cpp:promoted_type@222] Assertion failure: a->is<TensorType>() && b->is<TensorType>(). The root cause is thattaichi_ngpusesatomic_subon a value with type different from the destination, which will generateneg+cast. However, theret_typeandcast_typeofUnaryOpStmtproduced byScalarizearen't set correctly. This PR fixes the problem.