Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl] Enable more gles tests in CI #7031

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Jan 3, 2023

Issue: #

Brief Summary

Reland of #7010 with a hack that running gles tests alone. Wanted to enable the tests to prevent regression, will fix the crash that happens when testing vulkan,gles,opengl at the same time.

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 3ea80de
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63b5101a8423db0009e2e7be

@ailzhang
Copy link
Contributor Author

ailzhang commented Jan 4, 2023

/rebase

Reland of taichi-dev#7029 with a hack that running gles tests alone.
Wanted to enable the tests to prevent regression, will fix the crash that happens when
testing vulkan,gles,opengl at the same time.
Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ailzhang ailzhang merged commit 7d1e287 into taichi-dev:master Jan 4, 2023
@ailzhang ailzhang deleted the enable_gles_tests branch January 4, 2023 06:37
feisuzhu pushed a commit to feisuzhu/taichi that referenced this pull request Jan 5, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants