[ir] Replace FuncCallExpression with FrontendFuncCallStmt #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 3, 2023
ghstack-source-id: 72724be4ea0a81c0626af0e5f2b44c69fceab207 Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 3, 2023
ghstack-source-id: 84875d59668f6dfbd5a53fd15da2c3022ae3a149 Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 3, 2023
ghstack-source-id: eb47590decf5fe65d1d35950426594e370805716 Pull Request resolved: #7027
lin-hitonami
requested review from
strongoier,
ailzhang,
jim19930609 and
bobcao3
bobcao3
reviewed
Jan 3, 2023
bobcao3
reviewed
Jan 3, 2023
bobcao3
reviewed
Jan 3, 2023
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 4, 2023
ghstack-source-id: d1591f62a4274b6b3eaaafda4267b88329c917c8 Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 4, 2023
ghstack-source-id: 9358cce6498ce824ccfd9e8363327dcb5a341b91 Pull Request resolved: #7027
for more information, see https://pre-commit.ci
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 4, 2023
ghstack-source-id: 600fb6de8582f81546d888374820d13929ceeb11 Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 4, 2023
ghstack-source-id: 8631eb78a57bf4beddbbd026faf27579e282675d Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 5, 2023
ghstack-source-id: a030a0b4fcba4c60337e8c80e586a2526187e8d2 Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 5, 2023
ghstack-source-id: da0bfef346214d258ef00f52339d370ae0f95ae1 Pull Request resolved: #7027
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
requested review from
strongoier,
jim19930609,
ailzhang and
bobcao3
and removed request for
strongoier,
ailzhang,
bobcao3 and
jim19930609
issue: #6983 FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
issue: #6983 FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number. [ghstack-poisoned]
lin-hitonami
added a commit
that referenced
this pull request
Jan 6, 2023
ghstack-source-id: 7ccf3062f461ad642aa03b61879060b86e37df18 Pull Request resolved: #7027
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
ghstack-source-id: 7ccf3062f461ad642aa03b61879060b86e37df18 Pull Request resolved: taichi-dev#7027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
issue: #6983
FuncCall is not just an expression. It executes code and returns the result. It should be more like FrontendAllocaStmt rather than being FuncCallExpression. If it is an expression, the IR printer handles it like an expression and prints the detail of the func call everywhere its return value is used. If it is a statement, it will only be printed once, and other statements/expressions reference its return value by its statement number.