Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ir] Change type maps to unordered maps and add mutexes #7000

Merged
merged 2 commits into from
Dec 29, 2022
Merged

[ir] Change type maps to unordered maps and add mutexes #7000

merged 2 commits into from
Dec 29, 2022

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented Dec 28, 2022 •
edited
Loading

Issue: fixes #6570 and resolves the TODOs in the code

Brief Summary

@netlify
Copy link

netlify bot commented Dec 28, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit e7e8cd6
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63ac15c27ba8a0000823aa45

jim19930609
jim19930609 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lin-hitonami lin-hitonami merged commit ccd02b0 into taichi-dev:master Dec 29, 2022
@lin-hitonami lin-hitonami deleted the map_to_unordered branch December 29, 2022 02:51
feisuzhu pushed a commit to feisuzhu/taichi that referenced this pull request Jan 5, 2023
@lin-hitonami @pre-commit-ci @feisuzhu
[ir] Change type maps to unordered maps and add mutexes (taichi-dev#7000
0be323f 
)

Issue: fixes taichi-dev#6570 and resolves the TODOs in the code

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@lin-hitonami @pre-commit-ci @quadpixels
[ir] Change type maps to unordered maps and add mutexes (taichi-dev#7000
acdfa8a 
)

Issue: fixes taichi-dev#6570 and resolves the TODOs in the code

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim19930609 jim19930609 jim19930609 approved these changes

@strongoier strongoier Awaiting requested review from strongoier

@ailzhang ailzhang Awaiting requested review from ailzhang

@bobcao3 bobcao3 Awaiting requested review from bobcao3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to add mutex to TypeFactory methods
2 participants
@lin-hitonami @jim19930609