Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix taichi_ngp starting from ti example #6973

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

ailzhang
Copy link
Contributor

If you start ti example and type 66 (taichi_ngp) it crashes and complains about unknown arg example. This PR fixes it.

Issue: #

Brief Summary

If you start `ti example` and type `66` (taichi_ngp) it crashes and complains about
unknown arg `example`. This PR fixes it.
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 0f5e5bd
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63a5a1d4f83a2600070cb42b
😎 Deploy Preview https://deploy-preview-6973--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feisuzhu feisuzhu merged commit 28b818d into taichi-dev:master Dec 23, 2022
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
If you start `ti example` and type `66` (taichi_ngp) it crashes and
complains about unknown arg `example`. This PR fixes it.

Issue: #

### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants