[lang] Migrate TensorType expansion for subscription indices from Python to Frontend IR #6942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon to Frontend IR
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
strongoier
reviewed
Dec 27, 2022
strongoier
reviewed
Dec 28, 2022
strongoier
reviewed
Jan 3, 2023
strongoier
approved these changes
Jan 4, 2023
feisuzhu
pushed a commit
to feisuzhu/taichi
that referenced
this pull request
Jan 5, 2023
…hon to Frontend IR (taichi-dev#6942) Issue: taichi-dev#5819 ### Brief Summary For indices of TensorType, instead of scalarizing them at Python level, it is up to the Frontend IR's consumer to decide whether TensorType'd indices are acceptable and if we should have it scalarized. This PR removes `expand_expr` in Expression subscription and migrate the scalarization logics to the following constructors: 1. MeshIndexConversionExpression::MeshIndexConversionExpression 2. IndexExpression::IndexExpression
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…hon to Frontend IR (taichi-dev#6942) Issue: taichi-dev#5819 ### Brief Summary For indices of TensorType, instead of scalarizing them at Python level, it is up to the Frontend IR's consumer to decide whether TensorType'd indices are acceptable and if we should have it scalarized. This PR removes `expand_expr` in Expression subscription and migrate the scalarization logics to the following constructors: 1. MeshIndexConversionExpression::MeshIndexConversionExpression 2. IndexExpression::IndexExpression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5819
Brief Summary
For indices of TensorType, instead of scalarizing them at Python level, it is up to the Frontend IR's consumer to decide whether TensorType'd indices are acceptable and if we should have it scalarized.
This PR removes
expand_exprin Expression subscription and migrate the scalarization logics to the following constructors: