Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aot] Fixed C-API behavior tests #6939

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

PENGUINLIONG
Copy link
Member

@PENGUINLIONG PENGUINLIONG commented Dec 20, 2022

Fixed allocation leakage, unchecked values, camel cases and uninitialized structs in behavior tests. Reflected in codes, this PR has done the following:

  1. Use lifetime guarded C++ wrapper for usage that are not the tested interface.
  2. Removed several success tests that might overlap with those in other tests. (This is not done completely, will make another PR to refactorize that.)

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 1d7db13
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63a2b6f7fe8c320009738843

@PENGUINLIONG PENGUINLIONG changed the title Fixed C-API behavior tests [aot] Fixed C-API behavior tests Dec 20, 2022
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks~

@PENGUINLIONG PENGUINLIONG merged commit a199fa1 into taichi-dev:master Dec 22, 2022
@PENGUINLIONG PENGUINLIONG deleted the fix-behavior-test branch December 22, 2022 02:25
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Fixed allocation leakage, unchecked values, camel cases and
uninitialized structs in behavior tests. Reflected in codes, this PR has
done the following:

1. Use lifetime guarded C++ wrapper for usage that are *not* the tested
interface.
2. Removed several *success* tests that might overlap with those in
other tests. (This is not done completely, will make another PR to
refactorize that.)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants