[vulkan] Improve Vulkan RHI impl with lower overhead internal implementations

taichi/rhi/device.h

@@ -17,6 +17,7 @@ enum class RhiResult {
   error = -1,
   invalid_usage = -2,
   not_supported = -3,
+  out_of_memory = -4,
 };
 
 constexpr size_t kBufferSizeEntireSize = size_t(-1);
@@ -54,7 +55,7 @@ struct LLVMRuntime;
 
 // TODO: Figure out how to support images. Temporary solutions is to have all
 // opque types such as images work as an allocation
-using DeviceAllocationId = uint32_t;
+using DeviceAllocationId = uint64_t;
 
 struct TI_DLL_EXPORT DeviceAllocation {
   Device *device{nullptr};

taichi/rhi/impl_support.h

@@ -2,6 +2,8 @@
 
 #include "taichi/rhi/device.h"
 #include <assert.h>
+#include <forward_list>
+#include <mutex>
 
 namespace taichi::lang {
 
@@ -89,5 +91,37 @@ struct BidirMap {
   }
 };
 
+// A synchronized list of objects that is pointer stable & reuse objects
+// It does not mark objects as used, and it does not free objects (destructor is
+// not called)
+template <class T>
+struct SyncedPtrStableObjectList {
+  std::mutex lock;
+  std::forward_list<T> objects;
+  std::vector<T *> free_nodes;
+
+  T &acquire() {
+    std::lock_guard<std::mutex> _(lock);
+    if (free_nodes.empty()) {
+      return objects.emplace_front();
+    } else {
+      T *obj = free_nodes.back();
+      free_nodes.pop_back();
+      return *obj;
+    }
+  }
+
+  void release(T *ptr) {
+    std::lock_guard<std::mutex> _(lock);
+    free_nodes.push_back(ptr);
+  }
+
+  void clear() {
+    std::lock_guard<std::mutex> _(lock);
+    objects.clear();
+    free_nodes.clear();
+  }
+};
+
 }  // namespace rhi_impl
 }  // namespace taichi::lang

taichi/rhi/opengl/opengl_device.cpp

@@ -562,7 +562,8 @@ DeviceAllocation GLDevice::allocate_memory(const AllocParams &params) {
 }
 
 void GLDevice::dealloc_memory(DeviceAllocation handle) {
-  glDeleteBuffers(1, &handle.alloc_id);
+  GLuint buffer = GLuint(handle.alloc_id);
+  glDeleteBuffers(1, &buffer);
   check_opengl_error("glDeleteBuffers");
 }
 
@@ -714,7 +715,8 @@ DeviceAllocation GLDevice::create_image(const ImageParams &params) {
 }
 
 void GLDevice::destroy_image(DeviceAllocation handle) {
-  glDeleteTextures(1, &handle.alloc_id);
+  GLuint texture = GLuint(handle.alloc_id);
+  glDeleteTextures(1, &texture);
   check_opengl_error("glDeleteTextures");
   image_to_dims_.erase(handle.alloc_id);
   image_to_int_format_.erase(handle.alloc_id);

taichi/rhi/vulkan/vulkan_api.cpp

@@ -369,6 +369,38 @@ IVkPipeline create_graphics_pipeline(VkDevice device,
   return obj;
 }
 
+IVkPipeline create_graphics_pipeline_dynamic(
+    VkDevice device,
+    VkGraphicsPipelineCreateInfo *create_info,
+    VkPipelineRenderingCreateInfoKHR *rendering_info,
+    IVkPipelineLayout layout,
+    IVkPipelineCache cache,
+    IVkPipeline base_pipeline) {
+  IVkPipeline obj = std::make_shared<DeviceObjVkPipeline>();
+  obj->device = device;
+  obj->ref_layout = layout;
+  obj->ref_cache = cache;
+  obj->ref_renderpass = nullptr;
+
+  create_info->pNext = rendering_info;
+  create_info->layout = layout->layout;
+
+  if (base_pipeline) {
+    create_info->basePipelineHandle = base_pipeline->pipeline;
+    create_info->basePipelineIndex = -1;
+  } else {
+    create_info->basePipelineHandle = VK_NULL_HANDLE;
+    create_info->basePipelineIndex = 0;
+  }
+
+  VkResult res =
+      vkCreateGraphicsPipelines(device, cache ? cache->cache : VK_NULL_HANDLE,
+                                1, create_info, nullptr, &obj->pipeline);
+  BAIL_ON_VK_BAD_RESULT_NO_RETURN(res, "failed to create graphics pipeline");
+
+  return obj;
+}
+
 IVkPipeline create_raytracing_pipeline(
     VkDevice device,
     VkRayTracingPipelineCreateInfoKHR *create_info,

taichi/rhi/vulkan/vulkan_api.h

@@ -167,6 +167,13 @@ IVkPipeline create_graphics_pipeline(VkDevice device,
                                      IVkPipelineLayout layout,
                                      IVkPipelineCache cache = nullptr,
                                      IVkPipeline base_pipeline = nullptr);
+IVkPipeline create_graphics_pipeline_dynamic(
+    VkDevice device,
+    VkGraphicsPipelineCreateInfo *create_info,
+    VkPipelineRenderingCreateInfoKHR *rendering_info,
+    IVkPipelineLayout layout,
+    IVkPipelineCache cache = nullptr,
+    IVkPipeline base_pipeline = nullptr);
 IVkPipeline create_raytracing_pipeline(
     VkDevice device,
     VkRayTracingPipelineCreateInfoKHR *create_info,