[bug] Fix flaky mass_spring_game_ggui.py on Mac M1 by setting up default values for VulkanCapabilities #6850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for VulkanCapabilities
✅ Deploy Preview for docsite-preview canceled.
|
jim19930609
changed the title
bobcao3
reviewed
Dec 9, 2022
taichi/rhi/vulkan/vulkan_device.h
Outdated
| bool wide_line; | ||
| bool surface; | ||
| bool present; | ||
| uint32_t vk_api_version = 0; |
There was a problem hiding this comment.
Nit: should use the bracket initializer syntax
uint32_t vk_api_version{0}
for more information, see https://pre-commit.ci
|
Question here: Why compiler didn't report 'use of uninitialized values' for the original code? |
I think this is a struct and it's "default initialized" as a struct object, just that the struct did not specify initial values of its members |
ailzhang
approved these changes
Dec 9, 2022
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…ult values for VulkanCapabilities (taichi-dev#6850) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac M1 does not support
wide_linewith Vulkan. However, device capability was initialized to random values which is why some examples are flaky on M1.Before this PR:
