[vulkan] Support texture type args in aot add_kernel #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ailzhang
force-pushed
the
add_kernel_texture
branch
from
cc2bb67 to
44ad637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
ti.types.texturehas been a template type so I didn't change that in this PR. But in the futureTextureTypemay support args other thannum_dimensionsso that users can provide all necessary info in the type hint. But that's out of scope for this PR.This PR just added support for texture type args in aot
add_kernelso that it can be used in AOT without cgraph, and it worth noticing that you're currently required to provide a template_args for texture type. But since we require enough info in rw_texture type annotation, you don't need to provide any template_args for rw_texture type.