Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Remove usage of deprecated num_channels/channel_format type hint in rw_texture in codebase #6791

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Dec 2, 2022

Issue: discovered by #6630, thanks @neozhaoliang !

Brief Summary

num_channels/channel_format will be deprecated in #6782 so let's remove them in the user facing codebase to suppress warnings.

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 2280c7a
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6389922f7a0df2000844eaac
😎 Deploy Preview https://deploy-preview-6791--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ailzhang ailzhang requested a review from neozhaoliang December 2, 2022 05:50
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 8bd91a7 into taichi-dev:master Dec 2, 2022
@ailzhang ailzhang deleted the suppress_warning_texture branch December 2, 2022 10:06
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants