Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU][CUDA] Support bitmasked as the leaf block structure for 1x1x1 masks #676

Merged
merged 6 commits into from
Mar 29, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu requested a review from k-ye March 29, 2020 00:49
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Left a few questions and nits

tests/python/test_sparse_basics.py Outdated Show resolved Hide resolved
taichi/codegen/codegen_llvm.h Outdated Show resolved Hide resolved
@yuanming-hu yuanming-hu requested a review from k-ye March 29, 2020 01:31
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuanming-hu yuanming-hu merged commit c2d1f85 into taichi-dev:master Mar 29, 2020
archibate pushed a commit to archibate/taichi that referenced this pull request Mar 31, 2020
…1` masks (taichi-dev#676)

* fixed CUDA misalignment; added test_bitmasked_bitmasked

* passed test_bitmasked_bitmasked

* restored all tests

* finalized. Thanks for @k-ye for the test case

* apply review patches

* comment and format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants