Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Enable packed mode by default #6721

Merged
merged 9 commits into from
Nov 25, 2022
Merged

Conversation

strongoier
Copy link
Contributor

@strongoier strongoier commented Nov 24, 2022

Issue: #6660

Brief Summary

This PR does the following:

  • Provides missing part of packed mode support for Metal sparse;
  • Removes ti.extension.packed;
  • Sets packed=True by default;
  • Fixes illegal tests.

@strongoier strongoier added the full-ci Run complete set of CI tests label Nov 24, 2022
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit c9f1998
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/637f38ef6607e60008eab8e9
😎 Deploy Preview https://deploy-preview-6721--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@strongoier strongoier changed the title [Lang] Use packed mode by default [Lang] Enable packed mode by default Nov 24, 2022
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit ac99979 into taichi-dev:master Nov 25, 2022
@strongoier strongoier deleted the packed-3 branch November 25, 2022 05:03
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#6660

### Brief Summary

This PR does the following:
- Provides missing part of packed mode support for Metal sparse;
- Removes `ti.extension.packed`;
- Sets `packed=True` by default;
- Fixes illegal tests.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Run complete set of CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants