Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Fix warning messages #6716

Merged
merged 2 commits into from
Nov 24, 2022
Merged

[Lang] Fix warning messages #6716

merged 2 commits into from
Nov 24, 2022

Conversation

neozhaoliang
Copy link
Contributor

@neozhaoliang neozhaoliang commented Nov 23, 2022

This PR fixes some warning messages in the official code. Also, forbid committing .ply files generated by running the diff_sph example in this repo.

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit e59b4a2
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/637dd146bf04da000a49c190
😎 Deploy Preview https://deploy-preview-6716--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neozhaoliang neozhaoliang merged commit d748795 into taichi-dev:master Nov 24, 2022
@neozhaoliang neozhaoliang deleted the fix-minmax-warning branch November 24, 2022 04:43
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
This PR fixes some warning messages in the official code. Also, forbid
committing `.ply` files generated by running the `diff_sph` example in
this repo.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants