Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aot] C-API Device capability improvements #6702

Merged
merged 15 commits into from
Nov 30, 2022

Conversation

PENGUINLIONG
Copy link
Member

@PENGUINLIONG PENGUINLIONG commented Nov 22, 2022

API adjustments, tests and etc.

This PR improves the user experience issue for C-API users to work with device capability, especially when the TiRuntime is imported from an outer context.

@netlify
Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit ab5ce49
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6386e9fd5d47370009786579
😎 Deploy Preview https://deploy-preview-6702--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a nit!

c_api/include/taichi/cpp/taichi.hpp Outdated Show resolved Hide resolved
@PENGUINLIONG PENGUINLIONG merged commit c27a2e4 into taichi-dev:master Nov 30, 2022
@PENGUINLIONG PENGUINLIONG deleted the capi-devcap3 branch November 30, 2022 08:52
PENGUINLIONG added a commit that referenced this pull request Nov 30, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
API adjustments, tests and etc.

This PR improves the user experience issue for C-API users to work with
device capability, especially when the `TiRuntime` is imported from an
outer context.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ailing  <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants