-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aot] C-API Device capability improvements #6702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PENGUINLIONG
force-pushed
the
capi-devcap3
branch
from
November 22, 2022 14:55
231262d
to
9e80d86
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
PENGUINLIONG
force-pushed
the
capi-devcap3
branch
from
November 28, 2022 07:54
cd553e9
to
7c4f428
Compare
ailzhang
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a nit!
Co-authored-by: Ailing <[email protected]>
PENGUINLIONG
added a commit
that referenced
this pull request
Nov 30, 2022
This reverts commit c27a2e4.
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
API adjustments, tests and etc. This PR improves the user experience issue for C-API users to work with device capability, especially when the `TiRuntime` is imported from an outer context. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ailing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API adjustments, tests and etc.
This PR improves the user experience issue for C-API users to work with device capability, especially when the
TiRuntime
is imported from an outer context.