[llvm] Let real function support returning struct #6614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lin-hitonami
changed the title
lin-hitonami
force-pushed
the
real_func_struct
branch
from
67e8179 to
cf0b6c7
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Using U64 array types and doing pointer conversion is really bad. This prohibits the downstream compiler to do any sort of optimization on this array (because of pointer conversions), and it uses a lot of register space & causes larger spilling issue. |
Yeah, please look at the Possible Improvement section of #6590 , I will compile it into a real struct in the future. |
bobcao3
reviewed
Nov 20, 2022
# Conflicts: # taichi/codegen/llvm/codegen_llvm.cpp
for more information, see https://pre-commit.ci
|
/rebase |
|
Rebase failed, please resolve the conflicts manually. |
|
Constructed the result buffer directly into a |
PGZXB
added a commit
that referenced
this pull request
Dec 19, 2022
PGZXB
added a commit
to PGZXB/taichi
that referenced
this pull request
Dec 19, 2022
Issue: taichi-dev#4401, taichi-dev#6614 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#602 taichi-dev#6590 ### Brief Summary Only supports scalar struct (every element in the struct is a scalar) for now. This PR does the following things: 1. Let `FuncCallStmt` return the `real_func_ret_struct *` result buffer instead of returning the return value directly. 2. Add `GetElementStmt` and `GetElementExpression` to get the i-th return value in a result buffer 3. Add `StructType.from_real_func_ret` to construct the returned struct to the `StructType` in Python Will add support for nested struct and matrix in struct in the following PRs. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#4401, taichi-dev#6614 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #602 #6590
Brief Summary
Only supports scalar struct (every element in the struct is a scalar) for now.
This PR does the following things:
FuncCallStmtreturn thereal_func_ret_struct *result buffer instead of returning the return value directly.GetElementStmtandGetElementExpressionto get the i-th return value in a result bufferStructType.from_real_func_retto construct the returned struct to theStructTypein PythonWill add support for nested struct and matrix in struct in the following PRs.