[Lang] Matrix lib: Stop changing dimension in transpose() #6528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
jim19930609
approved these changes
Nov 7, 2022
strongoier
added a commit
that referenced
this pull request
Dec 6, 2022
Issue: #5819 ### Brief Summary The background is that we would like to clearly distinguish vectors from matrices. After #6528, `transpose()` of a vector makes no sense so we'd better raise an error and guide users towards the current practice (`outer_product()`). Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…#6528) Issue: taichi-dev#5819 ### Brief Summary This PR enforces that `vector.transpose()` returns a vector while `matrix.transpose()` returns a matrix, which mimics the behavior of numpy. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…dev#6813) Issue: taichi-dev#5819 ### Brief Summary The background is that we would like to clearly distinguish vectors from matrices. After taichi-dev#6528, `transpose()` of a vector makes no sense so we'd better raise an error and guide users towards the current practice (`outer_product()`). Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5819
Brief Summary
This PR enforces that
vector.transpose()returns a vector whilematrix.transpose()returns a matrix, which mimics the behavior of numpy.