[lang] Add support for struct on Dynamic SNode #6502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lin-hitonami
force-pushed
the
dynamic_struct
branch
from
27e6c19 to
2b1e541
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
lin-hitonami
requested review from
strongoier,
ailzhang,
jim19930609 and
yuanming-hu
jim19930609
reviewed
Nov 3, 2022
for more information, see https://pre-commit.ci
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#5420 ### Brief Summary This PR lets `SNodeOpExpression` store `vector<Expr> values` instead of `Expr value`, and enables passing a struct to `ti.append`. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5420
Brief Summary
This PR lets
SNodeOpExpressionstorevector<Expr> valuesinstead ofExpr value, and enables passing a struct toti.append.