[llvm] Add support for data types of different sizes on dynamic SNode #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
lin-hitonami
changed the title
lin-hitonami
requested review from
ailzhang,
strongoier,
jim19930609 and
yuanming-hu
lin-hitonami
commented
Nov 1, 2022
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…taichi-dev#6490) Issue: taichi-dev#5420 ### Brief Summary This PR splits `append` operation of Dynamic SNode to two steps: 1. Allocate the space for the new element, increase the length by one, and return the address (void *) to the first byte of the new element. 2. Use `GetChStmt` to get the pointer of the element (of the right type) from the address returned in step 1, and use `GlobalStoreStmt` to store the value into the address. **This PR breaks Dynamic SNode on Metal** Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5420
Brief Summary
This PR splits
appendoperation of Dynamic SNode to two steps:GetChStmtto get the pointer of the element (of the right type) from the address returned in step 1, and useGlobalStoreStmtto store the value into the address.This PR breaks Dynamic SNode on Metal