Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dx12] Only use llvm to compile dx12. #6339

Merged
merged 2 commits into from
Oct 18, 2022
Merged

[dx12] Only use llvm to compile dx12. #6339

merged 2 commits into from
Oct 18, 2022

Conversation

python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Oct 17, 2022 •
edited
Loading

Add Dx12ProgramImpl.
Prepare change to launch dx12 kernel like dx11 instead of LlvmRuntimeExecutor.
Because dx12 uses buffer instead of pointer directly.

Issue: #5276

@python3kgae
[dx12] only use llvm to compile dx12.
289426d 
Add Dx12ProgramImpl.
Prepare change to launch dx12 kernel like dx11 instead of LlvmRuntimeExecutor.
@netlify
Copy link

netlify bot commented Oct 17, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 8f511a7
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/634ca2d1fd11820008468811

@python3kgae python3kgae marked this pull request as draft October 17, 2022 00:32
@feisuzhu feisuzhu changed the title [dx12] only use llvm to compile dx12. [dx12] Only use llvm to compile dx12. Oct 17, 2022
@python3kgae python3kgae marked this pull request as ready for review October 17, 2022 03:45
@python3kgae python3kgae requested a review from ailzhang October 17, 2022 03:45
ailzhang
ailzhang approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit a9f0eaa into taichi-dev:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@lin-hitonami lin-hitonami Awaiting requested review from lin-hitonami

@strongoier strongoier Awaiting requested review from strongoier

@PGZXB PGZXB Awaiting requested review from PGZXB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@python3kgae @ailzhang