Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Throw proper error message if calling ti.append with vector/matrix #6322

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ailzhang
Copy link
Contributor

related: #6205

Issue: #

Brief Summary

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 721264b
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63493dc2d5d09b0009f972f3
😎 Deploy Preview https://deploy-preview-6322--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@neozhaoliang neozhaoliang reopened this Oct 14, 2022
@neozhaoliang neozhaoliang self-requested a review October 14, 2022 06:16
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@ailzhang
Copy link
Contributor Author

/rerun

@ailzhang
Copy link
Contributor Author

/rebase

@ailzhang ailzhang merged commit 7319935 into taichi-dev:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants