[aot] Clean up exported symbols for libtaichi_c_api.so #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jim19930609
force-pushed
the
c_api_symbol_export
branch
from
56653bf to
c994296
Compare
jim19930609
changed the title
jim19930609
changed the title
jim19930609
changed the title
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: fix taichi-dev#5872, RFC taichi-dev#6722 *Note: This PR will also remove GGUI symbols from libtaichi_c_api.so on MacOS. Do not have this PR merged until we replaced all the GGUI renderers in taichi-aot-demos. **After this PR, libtaichi_c_api.so exports the following symbols:** Linux: [c_api_linux_exports.txt](https://github.com/taichi-dev/taichi/files/10102729/c_api_linux_exports.txt) Windows: [c_api_windows_exports.txt](https://github.com/taichi-dev/taichi/files/9624666/c_api_windows_exports.txt) MacOS: [c_api_mac_exports.txt](https://github.com/taichi-dev/taichi/files/9624830/c_api_mac_exports.txt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fix #5872, RFC #6722, #6793
*Note: This PR will also remove GGUI symbols from libtaichi_c_api.so on MacOS. Do not have this PR merged until we replaced all the GGUI renderers in taichi-aot-demos.
After this PR, libtaichi_c_api.so exports the following symbols:
Linux: c_api_linux_exports.txt
Windows: c_api_windows_exports.txt
MacOS: c_api_mac_exports.txt