[Misc] Add prefix sum executor to avoid multiple field allocations #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
YuCrazing
changed the title
YuCrazing
changed the title
YuCrazing
changed the title
ailzhang
reviewed
Sep 22, 2022
…g/taichi-1 into yuzhang/add_prefix_sum_executor
for more information, see https://pre-commit.ci
ailzhang
reviewed
Sep 22, 2022
ailzhang
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
LGTM, thanks!
Two nits before merging:
- docstring ;)
- You probably want to track user facing APIs here https://github.com/taichi-dev/taichi/blob/master/tests/python/test_api.py#L146 to avoid accidental changes ;)
Co-authored-by: Ailing <[email protected]>
Co-authored-by: Ailing <[email protected]>
…g/taichi-1 into yuzhang/add_prefix_sum_executor
for more information, see https://pre-commit.ci
…g/taichi-1 into yuzhang/add_prefix_sum_executor
for more information, see https://pre-commit.ci
|
/rebase |
|
Rebase failed, please resolve the conflicts manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrefixSumExecutorhelper to avoid every prefix sum function call's memory allocation.parallel_sortandprefix_sumutilities from_kernels.pytoalgorithms.py.Maybe we can also integrate @yuanming-hu 's CPU prefix sum into
PrefixSumExecutorin the future.