[Metal] Move Metal shader code to shaders/ folder #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuanming-hu Just FYI, I will probably just merge this in after CI, because it's mostly refactoring.. |
|
(Sorry for spamming here but I don't want to send notifications to everyone.) Are you good with the new code style: #592? If so I'll reformat everything in 12 hours. |
|
Sure, i'm fine with any coding style :) |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue id = #593
I created the prolog and epilog code snippet for Metal shaders. They will be more useful when I add the runtime shaders.
We can also use the shader code on both the host and device sides now. This somewhat reduces the necessity of #604 :)