Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dx12] Add aot for dx12. #6099

Merged
merged 13 commits into from
Sep 27, 2022
Merged

[dx12] Add aot for dx12. #6099

merged 13 commits into from
Sep 27, 2022

Conversation

python3kgae
Copy link
Contributor

Only make sure the pipeline generate something.
No real dxil generated yet.

Move DX12 build to gpu ci which will run the aot test.

Issue: #5276

@netlify
Copy link

netlify bot commented Sep 19, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 09d6de3
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63327d20e66c38000963aa57
😎 Deploy Preview https://deploy-preview-6099--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ailzhang
Copy link
Contributor

@python3kgae FYI we're going to merge #5846 soon after branchcut for v1.1.3 tmr which might conflict with this PR, would you mind holding on this PR a bit and rebase on top of that once it's merged? Thanks a lot! cc: @strongoier @feisuzhu

@python3kgae
Copy link
Contributor Author

@python3kgae FYI we're going to merge #5846 soon after branchcut for v1.1.3 tmr which might conflict with this PR, would you mind holding on this PR a bit and rebase on top of that once it's merged? Thanks a lot! cc: @strongoier @feisuzhu

Sure. I'll rebase once #5846 is in.

jim19930609
jim19930609 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! Btw you can further add test cases with "[python] aot_save + [C++] aot_load_and_run", with reference to https://github.com/taichi-dev/taichi/pull/5594/files

taichi/jit/jit_session.cpp Show resolved Hide resolved
taichi/runtime/dx12/aot_module_builder_impl.cpp Outdated Show resolved Hide resolved
@python3kgae
Copy link
Contributor Author

Nice work, thanks! Btw you can further add test cases with "[python] aot_save + [C++] aot_load_and_run", with reference to https://github.com/taichi-dev/taichi/pull/5594/files

Tried to make it work.
But crash in void Kernel::operator()(LaunchContextBuilder &ctx_builder) {.
Will add it next PR.

@python3kgae python3kgae force-pushed the aot_dx12 branch 2 times, most recently from bce9912 to 4124d46 Compare September 21, 2022 02:49
feisuzhu
feisuzhu reviewed Sep 26, 2022
View reviewed changes
.github/workflows/scripts/win_build.ps1 Outdated Show resolved Hide resolved
ci/windows/win_build_test.ps1 Show resolved Hide resolved
.github/workflows/scripts/win_build.ps1 Outdated Show resolved Hide resolved
@python3kgae python3kgae merged commit 73dac71 into taichi-dev:master Sep 27, 2022
@python3kgae python3kgae deleted the aot_dx12 branch September 27, 2022 05:47
feisuzhu added a commit to feisuzhu/taichi that referenced this pull request Oct 9, 2022
@feisuzhu
Revert "[dx12] Add aot for dx12. (taichi-dev#6099)"
d6ebddd 
This reverts commit 73dac71.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feisuzhu feisuzhu feisuzhu left review comments

@jim19930609 jim19930609 jim19930609 approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

@qiao-bo qiao-bo Awaiting requested review from qiao-bo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@python3kgae @ailzhang @feisuzhu @jim19930609